Skip to content

Conversation

@malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Jul 30, 2025

Fixes WOOMOB-890

Description

Note: I have NOT tested this PR, so please make sure to verify the value is correctly propagated to Stripe. I tried building the app locally (I don't have current provisioning profiles) and I tried downloading the firebase version (it doesn't support TTP).

The Android and iOS apps have been sending cots_device value in the reader_model parameter/meta-data on PaymentIntent.

However, with the update of Stripe SDK, we renamed this value to TAP_TO_PAY_DEVICE on Android.

The goal of this task is to bring iOS to consistency with Android and change the value to TAP_TO_PAY_DEVICE. The WooPayments server handles the value correctly after the merge of https://github.com/Automattic/transact-platform-server/pull/7539.

Testing information

  1. Open the app on an iPhone
  2. Tap on Orders
  3. Tap on the Plus button
  4. Add a product to the order
  5. Tap on Collect Payment
  6. Tap on Tap to Pay
  7. Follow the instructions and complete the payment
  8. Go to dashboard.stripe.com on your computer and verify the payment intent has TAP_TO_PAY_DEVICE value in the reader model.
Screenshot 2025-07-30 at 15 11 42

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added the feature: mobile payments Related to mobile payments / card present payments / Woo Payments. label Jul 30, 2025
@malinajirka malinajirka added this to the 23.0 milestone Jul 30, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 30, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15961-8428919
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commit8428919
Installation URL3fnrn424hje98
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@malinajirka malinajirka requested a review from iamgabrielma July 30, 2025 13:14
@malinajirka malinajirka marked this pull request as ready for review July 31, 2025 06:48
@iamgabrielma
Copy link
Contributor

Thanks for working on this! I'll review this one tomorrow as I was outside today without the testing card for TTP 🙇

Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Screenshot 2025-08-01 at 09 42 21

@malinajirka malinajirka enabled auto-merge August 1, 2025 07:39
@malinajirka malinajirka merged commit 2d54605 into trunk Aug 1, 2025
13 checks passed
@malinajirka malinajirka deleted the issue/woomob-890-in-person-payments-identifying-card-reader-model-ios-part branch August 1, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants